Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker builds to run gem update system with gem-update pinned to specific version that is compatible with ruby 2.7 #4275

Merged
merged 5 commits into from
Jan 30, 2024
Merged

fix docker builds to run gem update system with gem-update pinned to specific version that is compatible with ruby 2.7 #4275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
910dfec
fix docker builds to run gem update system with gem-update pinned to …
yuenmichelle1 Jan 23, 2024
0f48a89
update comments on why we pin gem-update and why updating system
yuenmichelle1 Jan 23, 2024
120985c
update comment with troubleshooting docs from miniracer readme
yuenmichelle1 Jan 23, 2024
75dec7c
Merge branch 'master' into fix-docker-build-to-use-pinned-gem-update
zwolf Jan 25, 2024
abcc50e
Merge branch 'master' into fix-docker-build-to-use-pinned-gem-update
zwolf Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ ADD ./Gemfile /rails_app/
ADD ./Gemfile.lock /rails_app/

RUN bundle config --global jobs `cat /proc/cpuinfo | grep processor | wc -l | xargs -I % expr % - 1`

# run gem update system so installation of mini_racer does not fail
# See troubleshooting for mini_racer and supported ruby versions: https://github.com/rubyjs/mini_racer?tab=readme-ov-file#supported-ruby-versions--troubleshooting
# pinning gem update to 3.4.22 since anything higher requires updating Ruby version to 3+
RUN gem i "rubygems-update:~>3.4.22" --no-document && update_rubygems
RUN bundle install --without development test

ADD ./ /rails_app
Expand Down
5 changes: 5 additions & 0 deletions Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ ADD ./Gemfile /rails_app/
ADD ./Gemfile.lock /rails_app/

RUN bundle config --global jobs `cat /proc/cpuinfo | grep processor | wc -l | xargs -I % expr % - 1`

# run `gem update system` so installation of mini_racer does not fail
# See troubleshooting for mini_racer and supported ruby versions: https://github.com/rubyjs/mini_racer?tab=readme-ov-file#supported-ruby-versions--troubleshooting
# pinning gem update to 3.4.22 since anything higher requires updating Ruby version to 3+
RUN gem i "rubygems-update:~>3.4.22" --no-document && update_rubygems
RUN bundle install

ADD ./ /rails_app
Expand Down
Loading