Add valid_email & confirmed_at to /me-only attributes

[zwolf]

Include User model attributes valid_email and confirmed_at in serialized user objects via the /me route. These attributes can then be used to indicate an invalid email or that an email address needs confirmation on the user's profile/settings page.

Review checklist

• First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
• If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
• If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
• Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

[yuenmichelle1]

Looks good. Do we want to add a test on users_controller spec for #me method tests?

[zwolf]

Private attrs are specced out already here:

panoptes/spec/serializers/user_serializer_spec.rb

Lines 74 to 94 in 42e4ec1

	describe "private user attributes" do
	let(:result) do
	UserSerializer.single({}, User.where(id: user.id), context)
	end
	let(:private_attrs) do
	UserSerializer::ME_ONLY_ATTRS - ["login_prompt"]
	end
	context "when i am the permitted requester" do
	let(:context) do
	{ requester: ApiUser.new(user) }
	end
	it 'should include the private user data', :aggregate_failures do
	private_attrs.each do |me_only_attr|
	private_user_data = user.send(me_only_attr)
	serialized_result = result[me_only_attr.to_sym]
	expect(serialized_result).to eq(private_user_data)
	end
	end
	end

The date comparison failed with a nanosecond-scale difference between the database & object values, hence the explicit setting of the confirmation attrs here.

edit: ope misread controller as serializer, yeah I'll add one for the controller spec!

[hound]

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

[hound]

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
RSpec/ExampleWording: Do not use should when describing your tests.