Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project copying fixes: Talk roles and field guide images #4258

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Oct 18, 2023

Fixes a couple project copying bugs.

  • Includes Field Guide attached images in project deep copies.
  • Creates Talk admin roles for copied projects. Uses the same TalkAdminCreateWorker that fires on project creation.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@zwolf zwolf merged commit d742f89 into master Oct 25, 2023
7 checks passed
@zwolf zwolf deleted the proj-copy-fixes branch October 25, 2023 18:42
@lcjohnso
Copy link
Member

Closes #4238 and #4251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants