Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non content resource translations language filtering #2446

Merged

Conversation

camallen
Copy link
Contributor

@camallen camallen commented Aug 24, 2017

partially address #1091 & #2348
closes #2405

Allow query param language filtering for non _content translation resources: Field Guide, Project/Org pages, Tutorials.

When no language query param is used it will default to "en" hard coded to match current behaviour.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

use a query param to specify the language for translation. A missing
param will default hardcoded "en" to match current behaviour.
@camallen camallen requested review from marten and zwolf August 24, 2017 15:21
Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@camallen camallen merged commit 422738c into zooniverse:master Aug 24, 2017
@camallen camallen deleted the non_content_resource_translations branch March 4, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests for tutorials don't respect the language parameter
2 participants