Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages are hardcoded to en language #2348

Closed
srallen opened this issue Jun 5, 2017 · 4 comments
Closed

Pages are hardcoded to en language #2348

srallen opened this issue Jun 5, 2017 · 4 comments

Comments

@srallen
Copy link
Contributor

srallen commented Jun 5, 2017

Found when debugging #2318, pages are hardcoded to en rather than set to the parent resource's primary_language on create. https://github.com/zooniverse/Panoptes/blob/master/app/controllers/concerns/pages.rb#L48

I think this may need to change to make translations work. Also, other linked resources like tutorials will need to be checked as they're also likely hardcoded to en right now.

@srallen srallen changed the title Pages is hardcoded to en language Pages are hardcoded to en language Jun 5, 2017
@camallen
Copy link
Contributor

camallen commented Jun 6, 2017

related to #1091

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Jul 12, 2017

Project 908 on staging has some copies of the research page (url_key = 'science_case') that I've set up with language codes 'it' and 'es', but only the English version of that page ever comes back from /api/project/908/pages?url_key='science_case'

@eatyourgreens
Copy link
Contributor

That might be correct behaviour, by the way, but the translations app would need a method to get all translations of a page back from the API.

@stale
Copy link

stale bot commented Nov 9, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 9, 2017
@stale stale bot closed this as completed Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants