Finish update before enqueueing worker (#4358)

* Complete super update before enqueueing worker

* Expect id to be a string

app/controllers/api/v1/aggregations_controller.rb

@@ -24,8 +24,7 @@ def create
   end
 
   def update
-    super do |agg|
-      AggregationCompletedMailerWorker.perform_async(agg.id) if update_params[:status]
-    end
+    super
+    AggregationCompletedMailerWorker.perform_async(params['id']) if update_params[:status]
   end
 end

spec/controllers/api/v1/aggregations_controller_spec.rb

@@ -111,14 +111,14 @@
     context 'with the mailer worker' do
       before do
         default_request scopes: scopes, user_id: authorized_user.id
-        allow(AggregationCompletedMailerWorker).to receive(:perform_async).with(resource.id)
+        allow(AggregationCompletedMailerWorker).to receive(:perform_async).with(resource.id.to_s)
       end
 
-      let(:params) { update_params.merge(id: resource.id) }
+      let(:params) { update_params.merge(id: resource.id.to_s) }
 
       it 'calls the mailer worker' do
         put :update, params: params
-        expect(AggregationCompletedMailerWorker).to have_received(:perform_async).with(resource.id)
+        expect(AggregationCompletedMailerWorker).to have_received(:perform_async).with(resource.id.to_s)
       end
 
       it 'does not call the mailer if status is not an updated param' do

spec/workers/aggregation_completed_mailer_worker_spec.rb

@@ -6,7 +6,7 @@
   let(:aggregation) { create(:aggregation) }
 
   it 'delivers the mail' do
-    expect { described_class.new.perform(aggregation.id) }.to change { ActionMailer::Base.deliveries.count }.by(1)
+    expect { described_class.new.perform(aggregation.id.to_s) }.to change { ActionMailer::Base.deliveries.count }.by(1)
   end
 
   context 'with missing attributes' do