missed hound review. update validate stats visibility to single line

zooniverse · Oct 28, 2023 · 4183b40 · 4183b40
1 parent e86811a
commit 4183b40
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/app/models/user_group.rb b/app/models/user_group.rb
@@ -41,9 +41,7 @@ class UserGroup < ApplicationRecord
   enum stats_visibility: STATS_VISIBILITY_LEVELS
 
   validate do
-    if @invalid_stats_visibility
-      errors.add(:stats_visibility, "Not stats_visibility type, please select from the list: #{STATS_VISIBILITY_LEVELS.keys}")
-    end
+    errors.add(:stats_visibility, "Not valid stats_visibility type, please select from the list: #{STATS_VISIBILITY_LEVELS.keys}") if @invalid_stats_visibility
   end
 
   validates :display_name, presence: true