implement batch aggregation on cli #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuenmichelle1
approved these changes
Oct 4, 2024
|
Looks fine to me. Maybe add some docs on the function definitions and the README? |
|
Docs seem fine to me. Since batch aggregation isn't meant for the everyday project builder, i'm wondering whether or not we should give a bit more context on batch aggregation. (Eg. what the zip file contains when you receive batch aggregation links. similar to what zach mentions in his docs as an issue. https://github.com/orgs/zooniverse/projects/44/views/2?pane=issue&itemId=67744402) But totally fine if the assumption is, someone running the batch agg commands in cli are in the know. And we can go ahead and merge. Either way is fine to me 👍🏼 In terms of documentation check, do a double check with @lcjohnso ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch aggregation client implementation