Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grommet experiment #173

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Upgrade grommet experiment #173

wants to merge 3 commits into from

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Dec 22, 2020

This is an experiment to see what the v1 to v2 Grommet is like. There are more components that could use updating, but I think functionally everything works, except:

  • I dropped in the ZooHeader from @zooniverse/react-components and the register link doesn't work. We could update this to not render if the registration function isn't defined.
  • The admin toggle for the footer isn't wired up. Is it needed still for this app?
  • Some components haven't been swapped for their newer Grommet equivalent, so aren't getting styling right now.
  • The app has few specs, so I'm unsure if everything is working:
    • It's unclear to me if the language Select is working as intended. Projects I try on staging don't have languages to choose from and the SO answer isn't really clear on how to use the app (i.e. just add a translator role user to the project). Are there more docs somewhere I missed?

@srallen srallen requested a review from eatyourgreens January 6, 2021 19:42
@srallen
Copy link
Contributor Author

srallen commented Jan 6, 2021

@eatyourgreens I worked on this before the holiday. I have a few questions above which would determine what if anything more needs to happen with this.

@eatyourgreens
Copy link
Contributor

https://pandora.zooniverse.org seems pretty broken, after a very quick look on my phone. I’d be inclined to hold off on any major work until there’s time and resources available for it.

@srallen
Copy link
Contributor Author

srallen commented Jan 6, 2021

@eatyourgreens this is a sandboxed research / experiment to understand what's involved in grommet major version update so that we know what'll be involved with Zooniverse Classrooms and this (Zoo Classrooms) will be having work done on it.

@srallen
Copy link
Contributor Author

srallen commented Jan 6, 2021

Answers to my questions would be appreciated because similar approaches will likely be taken with Zoo Classrooms. Thanks!

@srallen
Copy link
Contributor Author

srallen commented Jan 6, 2021

It'll also allow us to retire the old ZRC, theme, and other packages we don't really want to maintain anymore as a side benefit

@eatyourgreens
Copy link
Contributor

That's a good point. If you want to try out the app, to see how it works, I usually use Galaxy Zoo as a test. The project translations page in the project builder links through to translations in various languages. You'll probably need to enable admin mode in the project builder and in translations in order to see them. I guess that answers the question about admin n mode too.

The language selector should act as an autosuggest, but filtering out options that already exist as translations. From memory, selecting a new language fires the action that creates a new translation in Panoptes.

There's no requirement to use the official Zoo header and footer but they seem like a good idea if they aren't a lot of work to add.

@eatyourgreens
Copy link
Contributor

No need for registration here either. Anyone who's following a link to a translation would almost certainly be logged in already.

Better integration with the project builder might be nice, though. Eg. Sharing the admin mode cookie between the two.

@eatyourgreens
Copy link
Contributor

https://translations.zooniverse.org?env=staging won’t authenticate. I’ll see if I can fix that tomorrow. It might be missing from Doorkeeper.

@eatyourgreens
Copy link
Contributor

I've updated Doorkeeper on staging, so https://translations.zooniverse.org/?env=staging#/ works now if you want to play around with translations for your staging projects.

@eatyourgreens
Copy link
Contributor

Here's a screenshot of the language selector on one of my staging projects. I was right. It should suggest new languages as you type (but filter out existing languages.)

Screenshot of the language selector widget suggesting German and Georgian after I've typed 'ge'.

@srallen
Copy link
Contributor Author

srallen commented Jan 7, 2021

Thanks! I'll hope to have tiny bits of time throughout this month to finish having a look at this and then write up a strategy for updating for Zoo Classrooms.

Copy link
Contributor

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a comment so GitHub stops asking me to read this PR. Initial changes look good. The language selector and responsive layout on phones might be the big issues for this upgrade.

I'm not massively attached to the current selector layout, particularly on phones (#107).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants