-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade grommet experiment #173
base: main
Are you sure you want to change the base?
Conversation
@eatyourgreens I worked on this before the holiday. I have a few questions above which would determine what if anything more needs to happen with this. |
https://pandora.zooniverse.org seems pretty broken, after a very quick look on my phone. I’d be inclined to hold off on any major work until there’s time and resources available for it. |
@eatyourgreens this is a sandboxed research / experiment to understand what's involved in grommet major version update so that we know what'll be involved with Zooniverse Classrooms and this (Zoo Classrooms) will be having work done on it. |
Answers to my questions would be appreciated because similar approaches will likely be taken with Zoo Classrooms. Thanks! |
It'll also allow us to retire the old ZRC, theme, and other packages we don't really want to maintain anymore as a side benefit |
That's a good point. If you want to try out the app, to see how it works, I usually use Galaxy Zoo as a test. The project translations page in the project builder links through to translations in various languages. You'll probably need to enable admin mode in the project builder and in translations in order to see them. I guess that answers the question about admin n mode too. The language selector should act as an autosuggest, but filtering out options that already exist as translations. From memory, selecting a new language fires the action that creates a new translation in Panoptes. There's no requirement to use the official Zoo header and footer but they seem like a good idea if they aren't a lot of work to add. |
No need for registration here either. Anyone who's following a link to a translation would almost certainly be logged in already. Better integration with the project builder might be nice, though. Eg. Sharing the admin mode cookie between the two. |
https://translations.zooniverse.org?env=staging won’t authenticate. I’ll see if I can fix that tomorrow. It might be missing from Doorkeeper. |
I've updated Doorkeeper on staging, so https://translations.zooniverse.org/?env=staging#/ works now if you want to play around with translations for your staging projects. |
Thanks! I'll hope to have tiny bits of time throughout this month to finish having a look at this and then write up a strategy for updating for Zoo Classrooms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a comment so GitHub stops asking me to read this PR. Initial changes look good. The language selector and responsive layout on phones might be the big issues for this upgrade.
I'm not massively attached to the current selector layout, particularly on phones (#107).
This is an experiment to see what the v1 to v2 Grommet is like. There are more components that could use updating, but I think functionally everything works, except:
ZooHeader
from@zooniverse/react-components
and the register link doesn't work. We could update this to not render if the registration function isn't defined.