Update PFE and FEM's commit check URLs #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there any code I need to add to fe-root to make this work, or is there automatically a |
|
That file already exists (https://fe-root.zooniverse.org/commit_id.txt), it was added by the app-root dockerization PR. |
yuenmichelle1
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-switcheroo, www.zooniverse.org/commit_id.txt is served from the fe-root app, not PFE. This confuses lita, who uses that URL for PFE checks. This updates that check to use the
static.zooniverse.org/www.zooniverse.orgpath which still gets updated on PFE deploys but isn't served by www.Also updated FEM's check to check the fe-root app instead of projects. Using the app directly instead of www to avoid the CDN, just in case.