Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-user: Setup react-i18next for MainContent components #6561

Open
wants to merge 1 commit into
base: translations-shared-two
Choose a base branch
from

Conversation

goplayoutside3
Copy link
Contributor

Package

lib-user

Linked Issue

Builds on top of #6559

Describe your changes

Setup react-i18next for the MainContent components

How to Review

The expected text should display for the above components when lib-user is run locally, in Storybook, or as app-root pages.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)

New Feature

  • The PR creator has listed user actions to use when testing the new feature
  • Unit tests are included for the new feature
  • A storybook story has been created or updated
    • Example of SlideTutorial component with docgen comments, and its story

Post-merge

  • This PR adds translations keys to English dictionary(s). See guidance for pulling new keys to Lokalise here.

@goplayoutside3 goplayoutside3 added the translations Involves managing text translation label Dec 15, 2024
@goplayoutside3 goplayoutside3 changed the title Setup react-i18next for MainContent components lib-user: Setup react-i18next for MainContent components Dec 15, 2024
@goplayoutside3
Copy link
Contributor Author

goplayoutside3 commented Dec 15, 2024

Something I noticed while editing MainContent code is the <button> element in the Select components has an incorrect aria-label. It reads as "Selected: [object Object]" for the projects dropdown and the date range dropdown.
button in the dev tools

This is because Grommet's Select takes the value and puts it in the aria-label regardless if that value is an object or string. The helper functions that handle Select in MainContent span across multiple code files so I didn't want to get into a bug fix here, but just wondering if you're aware of this behavior and should I create an Issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Involves managing text translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant