Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib-user: Setup react-i18next for MyGroups components #6555

Open
wants to merge 1 commit into
base: translations-group-stats
Choose a base branch
from
Open

lib-user: Setup react-i18next for MyGroups components #6555

wants to merge 1 commit into from
+54 −27

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Dec 15, 2024 •
edited by mcbouslog
Loading

Package

lib-user

Linked Issue and/or Talk Post

Builds on top of #6554

Describe your changes

  • Setup react-i18next for MyGroups components

How to Review

The expected text should display for MyGroups components when lib-user is run locally, in Storybook, or as app-root pages.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)

New Feature

  • The PR creator has listed user actions to use when testing the new feature
  • Unit tests are included for the new feature
  • A storybook story has been created or updated
    • Example of SlideTutorial component with docgen comments, and its story

Post-merge

  • This PR adds translations keys to English dictionary(s). See guidance for pulling new keys to Lokalise here.

@goplayoutside3 goplayoutside3 added the translations Involves managing text translation label Dec 15, 2024
goplayoutside3
goplayoutside3 commented Dec 15, 2024
View reviewed changes
packages/lib-user/src/components/MyGroups/MyGroups.js
Comment on lines -55 to +58
<Paragraph margin={{ top: '0', bottom: '20px' }}>
You are not a member of any Groups.
</Paragraph>
<Paragraph margin={{ top: '0', bottom: '20px' }}>
Create one below
<Paragraph margin={{ top: '0', bottom: '20px' }} textAlign='center'>
<Trans i18nKey='MyGroups.noGroups' components={[ <br key='line-break' />]} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/zooniverse/front-end-monorepo/pull/6228/files#r1735238281. Trans inserts a line break here.

@goplayoutside3 goplayoutside3 mentioned this pull request Dec 15, 2024
Open
8 tasks
mcbouslog
mcbouslog approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. ✅

@github-actions github-actions bot added the approved This PR is approved for merging label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbouslog mcbouslog mcbouslog approved these changes

Assignees
No one assigned
Labels
approved This PR is approved for merging translations Involves managing text translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goplayoutside3 @mcbouslog