-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-project: Redesign how your stats are displayed on the classify page #6472
Merged
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4e1f716
create new YourProjectStats component with useSWR for data
goplayoutside3 015eaa1
create a stats container component and a RequireUser component
goplayoutside3 0a67bde
create ClassificationsChart component with VisX
goplayoutside3 d669f06
fix styling of ClassificationChart
goplayoutside3 abe26aa
remove all the legacy YourStats code
goplayoutside3 9468468
Delete FinishedForTheDay component per designer request
goplayoutside3 6db35bd
fix consistent returns warning
goplayoutside3 465891f
Merge branch 'master'
goplayoutside3 10a9912
add a mutate function for incrementing stats on classification
goplayoutside3 be27129
match Figma design and edit translation dictionaries
goplayoutside3 b8720b7
write unit tests for YourProjectStats
goplayoutside3 7705b3f
include mutate in the ClassifierWrapper useCallback
goplayoutside3 89251aa
be sure to increment session count on each classification
goplayoutside3 66ff700
add auth.checkCurrent() to usePanoptesAuth() hook
goplayoutside3 d7ec5b0
adjust layout of ClassifyPage
goplayoutside3 5624eb5
clean up translation keys
goplayoutside3 c59c58b
Merge branch 'master' into your-project-stats-refactor
goplayoutside3 89d5e36
Merge branch 'master' into your-project-stats-refactor
goplayoutside3 3f2b679
copy usePanoptesAuthToken hook behavior from lib-user into app-project
goplayoutside3 968154c
Merge branch 'master' into your-project-stats-refactor
goplayoutside3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,16 +55,6 @@ | |
"title": "There was an error in the classifier :(" | ||
} | ||
}, | ||
"FinishedForTheDay": { | ||
"buttons": { | ||
"stats": "See the stats" | ||
}, | ||
"text": "Your answers are saved for the research team while you're working. See the project stats and return to the {{projectName}} home page.", | ||
"title": "Finished for the day?", | ||
"ProjectImage": { | ||
"alt": "Image for {{projectName}}" | ||
} | ||
}, | ||
"RecentSubjects": { | ||
"text": "Discuss a subject on Talk, or add it to your Favourites or a collection.", | ||
"title": "Your recent classifications" | ||
|
@@ -77,13 +67,10 @@ | |
"title": "New Workflow Available" | ||
}, | ||
"YourStats": { | ||
"todaysCount": "Classifications today", | ||
"totalCount": "Classifications total", | ||
"text": "Keep up the great work!", | ||
"title": "Your {{projectName}} statistics", | ||
"DailyClassificationsChart": { | ||
"title": "{{projectName}} daily classification counts" | ||
} | ||
"allTime": "All Time", | ||
"lastSeven": "Last 7 Days", | ||
"link": "See more", | ||
"title": "Your Stats" | ||
Comment on lines
-80
to
+72
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm able to reuse |
||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,7 +50,7 @@ | |
"dismiss": "今後メッセージを表示しない" | ||
}, | ||
"YourStats": { | ||
"title": "{{projectName}} 統計" | ||
"title": "統計" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ | |
}, | ||
"Classify": { | ||
"YourStats": { | ||
"title": "{{projectName}} statystyka" | ||
"title": "statystyka" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ | |
}, | ||
"Classify": { | ||
"YourStats": { | ||
"title": "{{projectName}} 数据" | ||
"title": "数据" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,7 @@ | |
"title": "這些是你最近完成的分類" | ||
}, | ||
"YourStats": { | ||
"title": "{{projectName}} 數據" | ||
"title": "數據" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is deleted for good, so its translation keys are deleted throughout.