Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mobx-devtools-mst #6414

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 29, 2024

Bumps mobx-devtools-mst from 0.9.30 to 0.9.34.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 29, 2024
@coveralls
Copy link

coveralls commented Oct 29, 2024

Coverage Status

coverage: 77.827% (+0.03%) from 77.793%
when pulling 055949d on dependabot/npm_and_yarn/mobx-devtools-mst-0.9.34
into 1d48e37 on master.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mobx-devtools-mst-0.9.34 branch 12 times, most recently from 73ce3e0 to eb99426 Compare November 12, 2024 14:41
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mobx-devtools-mst-0.9.34 branch 8 times, most recently from f222b7d to 62d2914 Compare November 14, 2024 16:54
@shaunanoordin
Copy link
Member

Why is this small bump triggering an error?

unhandledRejection ReferenceError: self is not defined
    at Object.<anonymous> (/home/runner/work/front-end-monorepo/front-end-monorepo/node_modules/mobx-devtools-mst/lib/index.js:1:342)

Let me re-run the tests.

@shaunanoordin
Copy link
Member

Tests are still failing upon a rerun. 🤨 This seems like it's going to be a thing, unfortunately.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mobx-devtools-mst-0.9.34 branch 5 times, most recently from b441db8 to 477b77d Compare November 20, 2024 18:15
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mobx-devtools-mst-0.9.34 branch 2 times, most recently from 5a24916 to f69f0e6 Compare November 21, 2024 21:37
@goplayoutside3
Copy link
Contributor

Weirdly, I can't replicate the error locally at all. Even if I run yarn workspace @zooniverse/fe-project build with env set to production like the CI build action, it works fine.

@goplayoutside3
Copy link
Contributor

goplayoutside3 commented Nov 21, 2024

But also this dependabot PR edits the yarn.lock to mobx-devtools-mst to v0.9.34, yet package.json for app-project and lib-classifier specify ~0.9.21 🤔 Edit: this does actually make sense.

Might be using this dependabot PR to simply remove the devtools if no one on the zoo team uses them.

Bumps [mobx-devtools-mst](https://github.com/mobxjs/mobx-devtools) from 0.9.30 to 0.9.34.
- [Changelog](https://github.com/mobxjs/mobx-devtools/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mobxjs/mobx-devtools/commits)

---
updated-dependencies:
- dependency-name: mobx-devtools-mst
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mobx-devtools-mst-0.9.34 branch from f69f0e6 to 216ec38 Compare November 21, 2024 22:27
@goplayoutside3
Copy link
Contributor

I suspect the error Shaun mentioned above is due to makeInspectable() being called on the server in _app.js. None of the dev team uses mobx-devtools-mst and there's lack of documentation from the most recent releases. Removing.

@goplayoutside3 goplayoutside3 changed the title build(deps): bump mobx-devtools-mst from 0.9.30 to 0.9.34 Remove mobx-devtools-mst Nov 22, 2024
@github-actions github-actions bot added the approved This PR is approved for merging label Nov 22, 2024
@goplayoutside3 goplayoutside3 merged commit 1862ade into master Nov 22, 2024
8 checks passed
@goplayoutside3 goplayoutside3 deleted the dependabot/npm_and_yarn/mobx-devtools-mst-0.9.34 branch November 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants