Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Refactor homepage recent projects to use ERAS #6409

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Oct 25, 2024

Package

lib-user

Linked Issue and/or Talk Post

Reverts: #6397
Closes: #6407
Talk thread: https://www.zooniverse.org/talk/2354/3435274?comment=5721484&page=13
Slack decision: https://zooniverse.slack.com/archives/C010QAPB67J/p1729885678034879?thread_ts=1729873643.092939&cid=C010QAPB67J

Describe your changes

  • Reverts changes to RecentProjects data fetching back to /project_preferences because displaying projects in exact order of recently classified takes precedence. See Slack convo for UI/UX decision.
  • Hides classification counts badge to remove discrepancy with ERAS counts on user stats pages.

Follow-up explanations on the linked Issue and Talk thread about expected ERAS behavior to follow.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages

@coveralls
Copy link

coveralls commented Oct 25, 2024

Coverage Status

coverage: 77.729%. remained the same
when pulling 7b107b1 on revert-recent-projects-fetch
into 963abe8 on master.

@mcbouslog mcbouslog self-assigned this Oct 25, 2024
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed changes locally 👍

@github-actions github-actions bot added the approved This PR is approved for merging label Oct 29, 2024
@mcbouslog mcbouslog removed their assignment Oct 29, 2024
@goplayoutside3 goplayoutside3 merged commit 3039260 into master Oct 29, 2024
8 checks passed
@goplayoutside3 goplayoutside3 deleted the revert-recent-projects-fetch branch October 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home page recent projects are shown in reverse order
3 participants