Migrate Sentry packages to v8 #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 7.109.0 to 8.34.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/8.34.0/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@7.109.0...8.34.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
goplayoutside3
added
the
dependencies
goplayoutside3
commented
Oct 15, 2024
| @@ -27,16 +26,13 @@ const handle = app.getRequestHandler() | |||
|
|
|||
| app.prepare().then(() => { | |||
| const server = express() | |||
|
|
|||
| server.use(Sentry.Handlers.requestHandler()) | |||
There was a problem hiding this comment.
Sentry.Handlers isn't needed anymore
goplayoutside3
commented
Oct 15, 2024
| @@ -0,0 +1,9 @@ | |||
| export async function register() { | |||
There was a problem hiding this comment.
mcbouslog
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Noted sentry console logs and network activity as expected when testing https://fe-project-branch.preview.zooniverse.org/ 👍
| disable: true, | ||
| }, | ||
| telemetry: false, | ||
| authToken: process.env.SENTRY_AUTH_TOKEN |
There was a problem hiding this comment.
It looks like this was not required previously, but is with these changes, it looks like per https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/#extend-your-nextjs-configuration .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package
app-project
lib-classifier
Linked Issue and/or Talk Post
Includes #6372
Reverts #4387
Describe your changes
How to Review
Initialising Sentry (browser runtime):"https://[email protected]/1492691" "branch""7351b3d6df09d1c95e3704bfa5582150d6668341"unless an adblocker affects it.Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrapordocker-compose up --buildand FEM works as expectedMaintenance