fix(classifier): reset hidden marks when the subject changes #6098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset the Hide Previous Marks toggle when a drawing task is reset. This should fix a bug where
task.hidingIndex
is remembered across subjects, which means that a volunteer won't see the first few marks that they draw on a new subject.That affects both drawing and transcription tasks, as both use the same code to store
task.hidingIndex
across subjects.Screen.Recording.2024-05-18.at.11.15.46.mov
Please request review from
@zooniverse/frontend
team or an individual member of that team.Package
Linked Issue and/or Talk Post
How to Review
You can test this on WildWatch Burrowing Owl. See the video above.
https://localhost:8080/?project=sandiegozooglobal/wildwatch-burrowing-owls&env=production&demo=true
Checking a transcription workflow would also be a good idea, as the same code is used by both transcription and drawing tasks. I’ve included tests for both tasks in this PR.
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Bug Fix