-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(classifier): automatically sync drawing annotations #5923
Open
eatyourgreens
wants to merge
4
commits into
zooniverse:master
Choose a base branch
from
eatyourgreens:refactor-drawing-annotations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(classifier): automatically sync drawing annotations #5923
eatyourgreens
wants to merge
4
commits into
zooniverse:master
from
eatyourgreens:refactor-drawing-annotations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
from
February 16, 2024 10:40
85df593
to
b15633f
Compare
Closed
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
6 times, most recently
from
February 18, 2024 18:58
34b0ba1
to
3df50f8
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
from
February 21, 2024 10:46
3df50f8
to
d8c06ec
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
4 times, most recently
from
March 15, 2024 17:44
cf4acb3
to
695697d
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
2 times, most recently
from
March 24, 2024 09:05
4cb512f
to
47569e6
Compare
Bumping this so it doesn’t go stale. |
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
2 times, most recently
from
March 28, 2024 14:22
e140319
to
2e07c8a
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
3 times, most recently
from
April 11, 2024 17:17
44b6f33
to
8d730de
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
from
April 22, 2024 07:36
8d730de
to
60572bd
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
3 times, most recently
from
May 8, 2024 08:23
9909c98
to
b219b6e
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
from
May 16, 2024 16:03
b219b6e
to
50ca414
Compare
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
from
May 19, 2024 12:05
50ca414
to
f8adb3a
Compare
5 tasks
eatyourgreens
changed the title
refactor: automatically sync drawing annotations
fix(classifier): automatically sync drawing annotations
May 23, 2024
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
from
May 23, 2024 17:00
f8adb3a
to
b358513
Compare
- Add an `annotation.actualTask` view to drawing tasks and transcription tasks. - Add an `autorun` listener which observes `self.actualTask.marks` for changes, and updates the annotation value. - Remove the manual `annotation.update(newValue)` when a new mark is drawn. This might be a more robust fix for problems where the classification is not updated properly after a change to a drawing tool. It should keep drawing annotations in sync with their corresponding drawing tools.
Use `annotation.value` to generate mark snapshots for `annotation.toSnapshot()`.
eatyourgreens
force-pushed
the
refactor-drawing-annotations
branch
from
June 17, 2024 16:45
b358513
to
028c50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotation.actualTask
view to drawing tasks and transcription tasks.autorun
reaction which observesself.actualTask.marks
for changes, and updates the annotation value.annotation.update(newValue)
when a new mark is drawn.annotation.toSnapshot()
to use the annotation value.This might be a more robust fix for problems where the classification is not updated properly after adding or removing a mark. It should keep drawing annotations in sync with their corresponding drawing tools. Whenever a drawing task's marks change, a MobX reaction updates the task's annotation.
Current behaviour, in production, is that adding a mark silently removes existing marks from the classification, except for the active frame. As a consequence, drawn marks appear to vanish from all frames in the subject viewer, except the active frame. See #5929.
Package
Linked Issue and/or Talk Post
How to Review
Similar to #5919, you should be able to draw marks on any frame of a subject, and those marks will still be recorded in the classification and shown on top of the subject in subsequent steps of a workflow.
For How Did We Get Here, you should be able to draw on both frames of a subject without apparently losing drawn marks in the second step of the workflow.
https://local.zooniverse.org:8080/?project=communitiesandcrowds/how-did-we-get-here&env=production
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Refactoring