Skip to content

Commit

Permalink
PR Fixes
Browse files Browse the repository at this point in the history
- Inline OrbitControls file to fix build issues
- Test removing lib-subject-viewers dependency
  • Loading branch information
kieftrav committed Oct 17, 2024
1 parent 5057416 commit a7dc6aa
Show file tree
Hide file tree
Showing 3 changed files with 1,539 additions and 9 deletions.
3 changes: 0 additions & 3 deletions packages/app-project/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@
"swr": "~2.2.0",
"validator": "~13.11.0"
},
"peerDependencies": {
"@zooniverse/subject-viewers": "0.1.0"
},
"devDependencies": {
"@babel/register": "~7.23.7",
"@storybook/addon-a11y": "~7.6.11",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,7 @@ import { useEffect, useLayoutEffect, useRef } from 'react'
import { Histogram } from './Histogram.js'
import { pointColor } from './../helpers/pointColor.js'
import { SortedSetUnion } from './../helpers/SortedSet.js'

// Shim for test:ci in GH needs this to work
let OrbitControls = null;
import("three/addons/controls/OrbitControls.js").then((module) => {
OrbitControls = module.OrbitControls;
})
import { OrbitControls } from './../helpers/OrbitControls.js'

// Shim for node.js testing
let glContext = null
Expand Down
Loading

0 comments on commit a7dc6aa

Please sign in to comment.