Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add already_seen flag to classification_events #80

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

yuenmichelle1
Copy link
Collaborator

  • Migration to add already_seen column to classification_events
  • Update fixture to a more recent looking classification payload coming from kinesis stream (Prior fixture is from 2016, what we send to the kinesis stream from panoptes has updated plenty since then)
  • Fetch already_seen from metadata on stream_events

Takes care of issue: #78

- Migration to add already_seen column to classification_events
- Update fixture to a more recent looking classification payload coming from kinesis stream
(Prior fixture is from 2016, what we send to the kinesis stream from panoptes has updated plenty since then)
- Fetch already_seen from metadata on stream_events
db/schema.rb Show resolved Hide resolved
db/schema.rb Show resolved Hide resolved
Copy link

@Tooyosi Tooyosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuenmichelle1 yuenmichelle1 merged commit 9aa47e6 into main Dec 2, 2024
4 checks passed
@yuenmichelle1 yuenmichelle1 linked an issue Dec 2, 2024 that may be closed by this pull request
@lcjohnso lcjohnso deleted the add-already_seen-to-classification_events branch December 4, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: ingest "already seen" classification metadata flag
2 participants