Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to order user project contributions by most recently contributed #76

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Add option to order user project contributions by most recently contributed #76

merged 7 commits into from
Oct 18, 2024

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented Oct 18, 2024 •
edited
Loading

See slack convo here: https://zooniverse.slack.com/archives/C010QAPB67J/p1719431470981999

For /classifications/users/:id, we add the option of order_project_contributions_by by either recents or count, default is to order project contributions by count.

Things to note:

  • project_contributions will not show up unless the param project_contributions=true.
  • When ordering project contributions by recents, ensure you set period=day to get "true" recents.

@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review October 18, 2024 17:52
zwolf
zwolf approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

app/serializers/user_classification_counts_serializer.rb Outdated Show resolved Hide resolved
app/serializers/user_classification_counts_serializer.rb Outdated Show resolved Hide resolved
@yuenmichelle1 yuenmichelle1 merged commit 52bb491 into main Oct 18, 2024
4 checks passed
@goplayoutside3 goplayoutside3 mentioned this pull request Oct 21, 2024
Merged
8 tasks
@yuenmichelle1 yuenmichelle1 deleted the add-option-to-order-user-project-contributions-by-most-recently-contributed branch October 24, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

@zwolf zwolf zwolf approved these changes

@mcbouslog mcbouslog Awaiting requested review from mcbouslog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuenmichelle1 @zwolf