add uniqueness constraints to cugs to take care of user_group_ids received from classrooms sometimes looking strange #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eived from classrooms sometimes looking strange
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
db/migrate/20231023161237_add_unique_index_to_classification_user_groups.rb
Show resolved
Hide resolved
zwolf
approved these changes
Oct 23, 2023
yuenmichelle1
deleted the
add-uniqueness-to-classification-user-groups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't happened yet, but I did notice that some classifications coming from classrooms will send
metadata.user_group_idswith duplicates. (Eg. user_group_ids: [1234, 1234, 1234]).Adding uniqueness constraints to classification_user_groups to ensure that duplicates do not get created for classification.
Prework:
checked if there were any duplicates in staging and production:
SQL query:
select * from classification_user_groups ou where (select count(*) from classification_user_groups inr where inr.classification_id = ou.classification_id and inr.user_group_id = ou.user_group_id) > 1there are 0 in both, but this could theoretically happen especially with finishing up the rest of ERAS backfill (Phase 4 Part 1, Creating Classification User Groups from backfilled classification_events)