Error reporting and wait for preparation task completion #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
report raised errors etc to honeybadger
we don't currently wait for the job preparation task to complete successfully as it leaves the node pool scaled if it doesn't finish properly so we're adding a configurable wait time on the main task start to allow the preparation task to finish and make the training / prediction code available. Without this the main task can run before the job preparation task has finished and we get errors like "python: can't open file '/mnt/batch/tasks/shared/train_model_finetune_on_catalog.py': [Errno 2] No such file or directory""
camallen
force-pushed
the
error-reporting-and-wait-prep-task
branch
from
eafa23f to
abe1ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15 and #10
This PR adds Honeybadger error reporting to the batch scripts to surface errors in the batch processing python code.
Finally this PR also adds a configurable wait time on main task start. This is needed as we don't currently wait for the job preparation task to complete successfully as it leaves the node pool scaled if it doesn't finish properly
so we're adding a configurable wait time on the main task start to allow the preparation task to finish and make the training / prediction code available.
Without this the main task can run before the job preparation task has finished and we get errors like "python: can't open file '/mnt/batch/tasks/shared/train_model_finetune_on_catalog.py': [Errno 2] No such file or directory""