-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch aggregation staging deploy #786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuenmichelle1
approved these changes
Jun 19, 2024
zwolf
added a commit
that referenced
this pull request
Jul 2, 2024
* Batch Aggregation (#785) * Add Celery and a test route * Add new dependencies * Test task tests * Docker updates * Scripts folder * Setup deploy to test env * Link redis container via docker * Modify test task * Add redis service to test workflow * Hook up services * Fix test arguments * flake8 * newline * rename and refactor * Taking a swing at extraction * oops * update .gitignore * Remove deploy files * Update .gitignore * Clean up test tests * Add router tests * Extremely placeholder BA lib tests * Only override local import * First few batch agg specs * Updates to BatchAggregation & tests * less flake8y * Add final POST message to Panoptes * Flake * flake * Pull etag before atempting update * Remove unnecessary mocks * Assert result set, not method called * clean up spec mocks * Add permissions checking, fix some specs, refactor Panoptes update * Flake * Use os.path for platform independence * Undeleting deploy template * Batch aggregation staging deploy (#786) * Add logging statements * Update celery task namespace * Add staging deployment template * Clean up new resource names * Build to a single docker image * Rename deployment & use Panoptes staging in staging deploy * Fix secret name * Sringify ID in comparison to value returned from Panoptes * Update test * Fix mock data type * Use client's admin mode * Fix a couple filepaths * Use UUID as tmpdir path * Finish run if Panoptes is unupdateable * When the update panoptes resource doesn't exist but the call is successful * Use jsonify to set mimetype * cast inputs to ints just in case * Enable public access to new containers * Deploy staging with action * hound? * test fixes * new hound * Use correct k8s secret * Use tag deployment for production (#788) * Use tag deployment for production * Add batchagg resources to prod template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a new staging deployment template, some additional logging, and a couple small fixes.
This new staging template currently deploys directly from the
batch-aggregation-staging
branch, not the head of master. I'll be testing locally with this after approval, then I'll add a workflow to automate the staging deploy. A dry run against the server with this template creates the following:I'm pretty sure that's everything this needs. I've created a new DNS record to point to the new staging app,
aggregation-staging.zooniverse.org
. I didn't include a deploy for Flower yet, let's see how this goes.