Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import for GUI #781

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix import for GUI #781

merged 1 commit into from
Mar 5, 2024

Conversation

lcjohnso
Copy link
Member

As part of #743, the import and override of progressbar got mangled during refactoring. Originally, there were two separate imports of progressbar from extract_panoptes_csv and reduce_panoptes_csv as pbe and pbr, respectively. The refactor reduced this to one (pbe) but didn't remove references to pbr. This issue causes the GUI not to start due to an error related to these imports:

Traceback (most recent call last):
  File "/Users/johnson/anaconda3/envs/main/bin/panoptes_aggregation_gui", line 5, in <module>
    from panoptes_aggregation.scripts.gui import gui
  File "/Users/johnson/anaconda3/envs/main/lib/python3.11/site-packages/panoptes_aggregation/scripts/gui.py", line 26, in <module>
    panoptes_aggregation.scripts.pbar_override(panoptes_aggregation.scripts.pbr)
                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'panoptes_aggregation.scripts' has no attribute 'pbr'. Did you mean: 'pbe'?

This PR makes the minor edit to change the import of progressbar to pb and to remove the duplicate pbar_override() call in scripts/gui.py.

@lcjohnso lcjohnso added the bug label Feb 29, 2024
@lcjohnso lcjohnso requested a review from CKrawczyk February 29, 2024 20:01
@CKrawczyk
Copy link
Collaborator

Tested locally, the GUI now loads as expected.

@lcjohnso lcjohnso merged commit d6b62be into master Mar 5, 2024
8 checks passed
@lcjohnso lcjohnso deleted the fix-pb-import branch March 5, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants