adding eps_t parameter to temporal tools for full 3D IoU calculation #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an
eps_t
which defines the temporal width of temporal shape tools, thereby constructing a fully 3D IoU. This metric uses thedisplayTime
attribute which is a normalized time value for the video, soeps_t
is essentially the fraction of the video that two shapes must overlap to be part of the same cluster.Also updating the solver from
scipy.optimize.shgo
toscipy.optimize.direct
. One main issue was that keepinglocally_biased
to True was causing poor convergence (particularly on the rectangle tool), butlocally_biased=False
is definitely much slower.