Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump markdown-to-jsx and grommet #332

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 5, 2024

Bumps markdown-to-jsx to 7.4.4 and updates ancestor dependency grommet. These dependencies need to be updated together.

Updates markdown-to-jsx from 6.11.4 to 7.4.4

Release notes

Sourced from markdown-to-jsx's releases.

v7.4.4

What's Changed

New Contributors

Full Changelog: quantizor/markdown-to-jsx@v7.4.3...v7.4.4

v7.4.3

What's Changed

Full Changelog: quantizor/markdown-to-jsx@v7.4.2...v7.4.3

v7.4.2

Re-release 7.4.1 with less existential console screaming

v7.4.1

What's Changed

New Contributors

Full Changelog: quantizor/markdown-to-jsx@v7.4.0...v7.4.1

v7.4.0

Happy New Year! 🎆

markdown-to-jsx v7.4 features a new option renderRule! — From the README:

Supply your own rendering function that can selectively override how rules are rendered (note, this is different than options.overrides which operates at the HTML tag level and is more general). You can use this functionality to do pretty much anything with an established AST node; here's an example of selectively overriding the "codeBlock" rule to process LaTeX syntax using the @matejmazur/react-katex library:

import { Markdown, RuleType } from 'markdown-to-jsx'
import TeX from '@matejmazur/react-katex'
</tr></table>

... (truncated)

Changelog

Sourced from markdown-to-jsx's changelog.

7.4.4

Patch Changes

  • 8eb8a13: Handle newlines inside of HTML tags themselves (not just nested children.)
  • c72dd31: Default children to an empty string if no content is passed.
  • 4f752c8: Fix handling of deeply-nested HTML in some scenarios.
  • 1486aa4: Handle extra brackets in links, thanks @​zegl!
  • 1486aa4: Allow a newline to appear within inline formatting like bold, emphasis, etc, thanks @​austingreco!
  • 1486aa4: Starting using changesets
  • fd35402: Fix HTML block regex for custom component scenarios where a nested component shares the same prefix as the parent, e.g. Accordion vs AccordionItem.
  • 1486aa4: Fix support for multi-line footnotes, thanks @​zegl!
Commits
  • 069b486 chore: update release script
  • 879f882 Version Packages (#556)
  • abeb55f chore: update site
  • c72dd31 refactor: don't throw if nothing is passed, just render nothing
  • 4f752c8 fix: deep html nesting
  • fd35402 fix: html block regex prefix conflict (#558)
  • 3af166c test: add regression test for image inside of link
  • 8eb8a13 fix: handle newlines inside HTML tag brackets (#557)
  • 1486aa4 chore: add changesets (#555)
  • 9ff42cf fix: gracefully handle missing image references (#554)
  • Additional commits viewable in compare view

Updates grommet from 1.13.0 to 2.41.0

Release notes

Sourced from grommet's releases.

v2.41.0

General:

  • Added theme.button.intelligentPad to Button. (#7307)
  • Added announce feature to DataChart for series labels. (#7310)
  • Fixed order preservation for selection in Select and SelectMultiple. (#7291)
  • Fixed issue with options being passed as objects in SelectMultiple within DataFilter. (#7313)

Drop:

  • Added a check to respect the autoFocus setting within Drop. (#7322)
  • Fixed trapFocus behavior to ensure focus remains within the container. (#7324)
  • Fixed Drop positioning. (#7320)

v2.40.2

v2.40.1

  • Resolved a performance issue cause by the styled components attrs function introduced in v2.39.0 of Grommet. (#7304)
  • Fixed an issue with Drop to prevent clicks on target from triggering onClickOutside. (#7300)
  • Fixed an accessibility issue with Accordion so that the AccordionPanel region has an accessible name. (#7295)

v2.40.0

  • Added defaultVisible prop to Tip to control the initial visibility of the tooltip. (grommet/grommet#7255)
  • Added showIndex boolean prop to List to control whether the index number for the list item is displayed when using onOrder. (grommet/grommet#7271)
  • Added view.columns to Data to track the visibility of columns in DataTableColumns and DataTable. (grommet/grommet#7281)

v2.39.0

General:

  • Added theme option of anchor.icon.color. (#7236)
  • Added tip to options for ToggleGroup. (#7258)
  • Added support for React 18.3.0. (grommet/grommet#7257)

v2.38.0

This release is compatible with both styled components v5 and v6. Please note that if you are upgrading to styled components v6 there are various changes to be aware of. Refer to the styled components migration guide: https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v6. One major difference in styled-components v6 is the removal of CSS vendor prefixes by default since most CSS styles have broad cross-browser support. If you’d like to enable vendor prefixes for your project, you can do so following the steps provided in the styled components migration guide.

v2.37.0

General:

  • NEW ToggleGroup component. (#7172)
  • Added pinned to DataTableColumns options to allow pinning of specific columns in “Order columns”. (#7193)
  • Enhanced List pinned to accept object containing icon, background, color, and items. (#7213)
  • Added extend to Skeleton theme. (#7176)
  • Fixed FormField error when child is null. (#7181)
  • Fixed Regex for autofocusing tags. (#7174)
  • Fixed List TypeScript types. (#7164)
  • Fixed Box round not respecting responsive={false}. (#7187)
  • Fixed select all behavior across Data views. (#7200)

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by jcfilben, a new releaser for grommet since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [markdown-to-jsx](https://github.com/quantizor/markdown-to-jsx) to 7.4.4 and updates ancestor dependency [grommet](https://github.com/grommet/grommet). These dependencies need to be updated together.


Updates `markdown-to-jsx` from 6.11.4 to 7.4.4
- [Release notes](https://github.com/quantizor/markdown-to-jsx/releases)
- [Changelog](https://github.com/quantizor/markdown-to-jsx/blob/main/CHANGELOG.md)
- [Commits](quantizor/markdown-to-jsx@6.11.4...v7.4.4)

Updates `grommet` from 1.13.0 to 2.41.0
- [Release notes](https://github.com/grommet/grommet/releases)
- [Commits](grommet/grommet@v1.13.0...v2.41.0)

---
updated-dependencies:
- dependency-name: markdown-to-jsx
  dependency-type: indirect
- dependency-name: grommet
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 5, 2024
@shaunanoordin
Copy link
Member

❗ This PR is no longer necessary.

  • The problem with markdown-to-jsx only affects Grommet v1's Markdown component, which ZRC doesn't use. Instead, ZRC uses Zooniverse's Markdownz for all things markdown-y.
  • As a result, the ZRC code is safe, even if Grommet isn't.
  • Also, this automated fix requires a major bump to Grommet (v1 to v2!), which breaks all our tests, and we don't plan to invest additional dev effort into ZRC at the moment.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/multi-f59f6482d5 branch November 5, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant