Remove feedback check for mobile compatibility (#7092)

* remove feedback check for mobile compatibility * run mobile feedback tests only for drawing workflow case * update inputs for mobile feedback tests making for drawing task only
zooniverse · May 6, 2024 · 2ef08f9 · 2ef08f9
1 parent 0f3b2db
commit 2ef08f9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/app/pages/lab/mobile/mobile-section-container.fixtures.js b/app/pages/lab/mobile/mobile-section-container.fixtures.js
@@ -97,6 +97,13 @@ const validationFixtures = {
   },
   taskFeedbackEnabled: {
     task: {
+      type: 'drawing',
+      tools: [
+        {
+          type: 'rectangle',
+          details: []
+        }
+      ],
       feedback: {
         enabled: true
       }

diff --git a/app/pages/lab/mobile/mobile-section-container.jsx b/app/pages/lab/mobile/mobile-section-container.jsx
@@ -101,15 +101,13 @@ function drawingTaskHasNoSubtasks({ task }) {
 const validatorFns = {
   single: {
     taskQuestionNotTooLong,
-    taskFeedbackDisabled,
     workflowHasSingleTask,
     workflowNotTooManyShortcuts: workflowHasNoMoreThanXShortcuts(2),
     workflowDoesNotUseGroupedSubjectSelection,
     workflowQuestionHasOneOrLessImages
   },
   multiple: {
     taskQuestionNotTooLong,
-    taskFeedbackDisabled,
     workflowHasSingleTask,
     workflowNotTooManyShortcuts: workflowHasNoMoreThanXShortcuts(2),
     workflowDoesNotUseGroupedSubjectSelection,

diff --git a/app/pages/lab/mobile/mobile-section-container.spec.js b/app/pages/lab/mobile/mobile-section-container.spec.js
@@ -118,8 +118,8 @@ describe('<MobileSectionContainer />', function () {
       testValidationProp('taskInstructionNotTooLong', validationFixtures.taskInstructionTooLong, false);
     });
 
-    it('should check whether the task uses feedback', function () {
-      testValidationProp('taskFeedbackDisabled');
+    it('should check whether the task uses feedback if the task type is drawing', function () {
+      testValidationProp('taskFeedbackDisabled', validationFixtures.workflowHasValidDrawingTask, true);
       testValidationProp('taskFeedbackDisabled', validationFixtures.taskFeedbackEnabled, false);
     });
 
@@ -187,7 +187,6 @@ describe('<MobileSectionContainer />', function () {
     it('should equal false if any of the validations aren\'t met', function () {
       [
         fixtures.validationFixtures.taskQuestionTooLong,
-        fixtures.validationFixtures.taskFeedbackEnabled,
         fixtures.validationFixtures.workflowHasMultipleTasks,
         fixtures.validationFixtures.workflowTooManyShortcuts,
         fixtures.validationFixtures.workflowUsesGroupedSubjectSelection