Implement ParseOption::indented_multiline_values #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented indented multiline values. This should be able to parse most
inifiles that the Pythonconfigparsercrate is able to parse.There are a lot of other things that the Python
configparsercrate is able to do, but there is no way we are quickly implementing all of it.I also decided against returning an Err in case of a multi-line key. I suspect that this will cause quite a few errors in programs that simply try to parse
configparser-like ini files and where some of the keys were just ignored. I'm not sure how to proceed there. I would definitely release a new minor or major version, because it will break some programs.Fixes #138.