Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update derailed_benchmarks.gemspec #247

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Update derailed_benchmarks.gemspec #247

merged 2 commits into from
Oct 11, 2024

Conversation

pcai
Copy link
Contributor

@pcai pcai commented Oct 4, 2024

probably rare issue, but its better to intentionally specify ruby-statistics 4.0.1 or greater, because thats the first version where the rename actually is in effect
see estebanz01/ruby-statistics#144

I confirmed that if we specifically bundle 4.0.0 in ruby 3.0+, it breaks:
image

@schneems
Copy link
Member

Seems good, thanks!

@schneems schneems merged commit e1fbebf into main Oct 11, 2024
67 checks passed
@pcai pcai deleted the ruby-statistics-4-fix branch October 11, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants