Add ortho_4x10 grid layout #2651
Open
+135
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caksoylar
reviewed
Nov 17, 2024
| ; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
This is missing a position map, is it not?
There was a problem hiding this comment.
hi! bottom row should be composed of 9 keys only - middle key composed of 2 unit space. the file renders correctly on my tests. i am not sure if i miss anything. thanks
update: please ignore my message above. position map for 1x2u added.
There was a problem hiding this comment.
I think you may have forgotten to update the names of the layouts below to 1x2u (line 54 and 55).
There was a problem hiding this comment.
thank you for the edit. i've gone thru the docs several times but it appears that failed to implement :(
caksoylar
reviewed
Nov 19, 2024
Co-authored-by: Cem Aksoylar <[email protected]>
caksoylar
reviewed
Nov 21, 2024
Co-authored-by: Cem Aksoylar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to add ortho_4x10 grid. Contains "all 1u" and "1x 2u" physical layouts.