Clear combo timer only when affected keys are released #2494
+95
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the key release listener checks if the released key is part of any combo candidate or active combo, instead of stopping the combo timer on any key release.
I also had to modify the
tap-dance/3b-tap-int-seq
test because it relied on the old combo release behavior, but I would like to double-check if this is the behavior we want to maintain.Fixes #2378