-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag updater #130
Tag updater #130
Conversation
5857e8a
to
3394dd3
Compare
3394dd3
to
e11ea17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zlant this is wonderful and awesome! I wanted to add a map to the updater tool but never got that far.
I rebased my version at https://tordans.github.io/parking-lanes/#15/58.4099/15.6220 based on this version, so we can use this for more testing.
I tested it in Berlin but it looks like @SupaplexOSM updated all the hard cases already (or my search was wrong).
Another great feature addition would be a way to highlight those lines that need updating on the map.
From my point of view, this looks great and could be merged!
I added on comment on css which caused an error because I used the updates packages version from #129.
Thinking about it some more: There are are a few parts of the UI that are hard coded, which provide hints if things needs to be reviewed manually. We should show those in the parkin-lanes app as well. I will have a look to expose them via a function that can be called from within the parking-lanes app. This is what I am referring to: https://github.com/osmberlin/osm-tag-updater/blob/main/src/components/Tool/Tool.tsx#L100-L160 |
caa885e
to
210f213
Compare
e0df175
to
3d4deb3
Compare
#93