updates job status on queue inclusion #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix potential indexer gap * Fix prover fee * Don't import FeeOptions * Use applyDenominator * Move INDEXER_BLOCK_CONFIRMATIONS to config
AllFi
reviewed
Jun 11, 2024
zp-relayer/pool/RelayPool.ts
Outdated
| async onConfirmed(res: ProcessResult<RelayPool>, txHash: string, callback?: () => Promise<void>): Promise<void> {} | ||
| async onFailed(txHash: string, jobId?: string): Promise<void> { | ||
| super.onFailed(txHash, jobId); | ||
| this.txStore.removeAll(); |
There was a problem hiding this comment.
Shouldn't we remove only one index? If the previous transaction was confirmed not too long ago and is not indexed by the indexer yet, then we remove it as well if I understand correctly.
Co-authored-by: Alexander Filippov <[email protected]>
Co-authored-by: Alexander Filippov <[email protected]>
Co-authored-by: Alexander Filippov <[email protected]>
r0wdy1
added a commit
that referenced
this pull request
Aug 7, 2024
* Initial TRON support * Fix error catching * Support for TRON address type in /limits endpoint * Minor refactoring * Remove mock proof * Make configurable feeLimit * Add MPC guard service * MPC relayer * Fix guard signatures * Fix guard signature * Update launch scripts * Add debug logs * Handle trongrid error * Initial * Update launch script * Ingore legacy ts errors * Fix memo offset * Fix commitment-watcher * Fix fetching limits from external accounting contract * Add /fee and /address endpoints for prover * Fix job state & RelayPool fetcher * Add /proverFee endpoint * Fix fee manager init * Fix RelayPool validation * Fix commitment processing condition (#215) * Add indexer service & make relayer stateless * Fix build * Add proxy optimistic state * Fix indexer sync * Add TxStore * Fix build * Fix indexer offset * Fix prover sync bug (#216) * Add direct deposits * Fix watcher init * updates job status on queue inclusion (#217) * updates job status on queue inclusion * Remove additional logic from getTransactionV2 * Added /proverAddress endpoint * Propagating job validation error * Job error description * Trying to restore balance waiting routine * Optimistic state for sent transactions * Updating txHash in cached txs, introducing pendingDeltaIndex field in /info endpoint * Setting reverted state to failed txs * Clearing pending cache on tx revert * Fix minor bugs (#218) * Fix potential indexer gap * Fix prover fee * Don't import FeeOptions * Use applyDenominator * Move INDEXER_BLOCK_CONFIRMATIONS to config * Update zp-relayer/workers/sentTxWorker.ts Co-authored-by: Alexander Filippov <[email protected]> * Update zp-relayer/pool/RelayPool.ts Co-authored-by: Alexander Filippov <[email protected]> * Update zp-relayer/pool/BasePool.ts Co-authored-by: Alexander Filippov <[email protected]> * make jobId mandatory for onFailed callback --------- Co-authored-by: Alexander Filippov <[email protected]> Co-authored-by: EvgenKor <[email protected]> * Fix basic dd logic (#219) * Add COMMITMENT_WATCHER_DIRECT_DEPOSIT_PARAMS_PATH * Fix dd indexing logic * Support both formats * Mark job as failed if the indexer isn't synced yet * Remove obsolete job * Fix sync * Fix sync * Attempt to fix dd flow * Remove unnecessary code * Refactor code * remove redundant methods --------- Co-authored-by: Alexander Filippov <[email protected]> Co-authored-by: r0wdy1 <[email protected]> Co-authored-by: EvgenKor <[email protected]> Co-authored-by: vladimir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.