refactor: 重构主题色配置功能 #110
Merged
refactor: 重构主题色配置功能 #110
+133
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j10ccc
reviewed
Sep 29, 2024
There was a problem hiding this comment.
page.config.js 不是放在 src 目录下的呀。它是放在每个页面的文件夹下，应该是用来替换 index.config.ts 的
|
feat:更新Taro版本,新增page.config.ts文件 这个 commit 是不是没有必要交上来啊？ |
xixiIBN5100
added a commit
that referenced
this pull request
Sep 29, 2024
This reverts commit 1c2a44d.
这个commit改了版本会导致action爆红,我在本地用第二个commit覆盖了修改然后合并的时候squash了一下.今天本地和远程仓库的commit出现了分歧进行了reset操作用的基准是这个commit,确实应该先把这个回退一下,之前不知到有检测缓存的action在本地更新了依赖以后也直接给组织的仓库pr了 |
j10ccc
reviewed
Oct 11, 2024
| <text | ||
| v-for="item in hadThemeList" |
There was a problem hiding this comment.
这里有类型错误，hadThemeList 的类型不是 ArrayLike @xixiIBN5100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.