Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ninja version due to bug in the latest version #305

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

johningve
Copy link
Contributor

There is a bug in the latest ninja package in PyPI, version 1.11.1.2, that causes ninja to call itself recursively until the system runs out of memory. This commit limits ninja to the previous version, 1.11.1.1, to prevent the issue.

There is a bug in the latest ninja package in PyPI, version 1.11.1.2,
that causes ninja to call itself recursively until the system runs out
of memory. This commit limits ninja to the previous version, 1.11.1.1,
to prevent the issue.
@johningve johningve requested a review from a team as a code owner December 5, 2024 13:10
@johningve johningve merged commit 8786f01 into master Dec 5, 2024
22 checks passed
@johningve johningve deleted the MISC-2024-12-05-freeze-ninja-version branch December 5, 2024 13:55
@dave992
Copy link

dave992 commented Dec 12, 2024

I am also running into this issue when running the pip install command. ninja --version keeps being called until the system runs out of memory. Unfortunately fixing the ninja version (or any of the other dependencies) did not seem to solve my issue.

We became aware of this problem 1-2 weeks ago.

Did you find any issue or merge request from ninja / pip / other relevant tool that is used where this behavior is reported? I only seem to find very old issues on the ninja issue tracker so far, although they do have some new comments:
ninja-build/ninja#2187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants