Support wrapping uninstantiated datamodel nodes #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johningve
force-pushed
the
MISC-2024-11-27-properly-support-uninstantiated-datamodels
branch
2 times, most recently
from
7ba28c0 to
aedd11b
Compare
vawale
previously approved these changes
Nov 28, 2024
Comment on lines
+344
to
+347
| if constexpr(isDirectChild(DM::path, ValueTypeContained::path)) | ||
| { | ||
| wrapDataModel<false>(dest, ValueTypeContained{}, true); | ||
| } |
There was a problem hiding this comment.
this is okay for now. I wonder if it makes better sense to have ValueTypeContained defined as part of DM::Descendants for leafDataModelList types. For example, defining using Settings::Acquisitions::Descendants = std::tuple<Settings::Acquisition>
Previously we just hardcoded the Settings/Acquisition and Settings2D/Acquisition nodes. This commit makes it work for any uninstantiated node that is part of a datamodelList by recursively searching the datamodel.
johningve
force-pushed
the
MISC-2024-11-27-properly-support-uninstantiated-datamodels
branch
from
aedd11b to
59373cb
Compare
vawale
approved these changes
Nov 28, 2024
johningve
deleted the
MISC-2024-11-27-properly-support-uninstantiated-datamodels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we just hardcoded the Settings/Acquisition and Settings2D/Acquisition nodes. This commit makes it work for any uninstantiated node that is part of a datamodelList by recursively searching the datamodel.