-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coding Challenge #14
Open
pyreta
wants to merge
12
commits into
zipmark:master
Choose a base branch
from
pyreta:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Coding Challenge #14
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fd44166
Basic Search with Flux
pyreta 58c5e58
Remove readme and license
pyreta ea895aa
Update README
pyreta 81e755e
Fix int conversion
pyreta ffbdad7
Add routing number display field
pyreta 7e3a87b
Remove commented code
pyreta 26da22d
Resolve root for relative directories
pyreta b64beda
Create BankDataParser class and abstract out Bank Display component
pyreta 9c41e40
Add specs and change jbuilder/DB formatting
pyreta c9a3470
Make Heroku Deployable
pyreta 76c8854
Add Production Gems
pyreta 0bc38cb
Handle no bank error
pyreta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
node_modules/ | ||
bundle.js | ||
bundle.js.map | ||
*tmp | ||
/tmp | ||
*sprockets | ||
notes.rb | ||
.DS_Store | ||
npm-debug.log | ||
.byebug_history |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
source 'https://rubygems.org' | ||
|
||
group :production do | ||
gem 'newrelic_rpm' | ||
gem 'rails_12factor' # error feedback | ||
end | ||
|
||
# Bundle edge Rails instead: gem 'rails', github: 'rails/rails' | ||
gem 'rails', '4.2.4' | ||
# Use postgresql as the database for Active Record | ||
gem 'pg' | ||
# Use SCSS for stylesheets | ||
gem 'sass-rails', '~> 5.0' | ||
# Use Uglifier as compressor for JavaScript assets | ||
gem 'uglifier', '>= 1.3.0' | ||
# Use CoffeeScript for .coffee assets and views | ||
gem 'coffee-rails', '~> 4.1.0' | ||
# See https://github.com/rails/execjs#readme for more supported runtimes | ||
# gem 'therubyracer', platforms: :ruby | ||
|
||
# Use jquery as the JavaScript library | ||
gem 'jquery-rails' | ||
# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder | ||
gem 'jbuilder', '~> 2.0' | ||
# bundle exec rake doc:rails generates the API under doc/api. | ||
gem 'sdoc', '~> 0.4.0', group: :doc | ||
|
||
gem 'pry-rails' | ||
|
||
gem 'http' | ||
|
||
gem 'rspec' | ||
|
||
gem 'colorize' | ||
# Use ActiveModel has_secure_password | ||
# gem 'bcrypt', '~> 3.1.7' | ||
|
||
# Use Unicorn as the app server | ||
# gem 'unicorn' | ||
|
||
# Use Capistrano for deployment | ||
# gem 'capistrano-rails', group: :development | ||
|
||
group :development, :test do | ||
# Call 'byebug' anywhere in the code to stop execution and get a debugger console | ||
gem 'byebug' | ||
end | ||
|
||
group :development do | ||
# Access an IRB console on exception pages or by using <%= console %> in views | ||
gem 'web-console', '~> 2.0' | ||
|
||
# Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring | ||
gem 'spring' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,210 @@ | ||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
actionmailer (4.2.4) | ||
actionpack (= 4.2.4) | ||
actionview (= 4.2.4) | ||
activejob (= 4.2.4) | ||
mail (~> 2.5, >= 2.5.4) | ||
rails-dom-testing (~> 1.0, >= 1.0.5) | ||
actionpack (4.2.4) | ||
actionview (= 4.2.4) | ||
activesupport (= 4.2.4) | ||
rack (~> 1.6) | ||
rack-test (~> 0.6.2) | ||
rails-dom-testing (~> 1.0, >= 1.0.5) | ||
rails-html-sanitizer (~> 1.0, >= 1.0.2) | ||
actionview (4.2.4) | ||
activesupport (= 4.2.4) | ||
builder (~> 3.1) | ||
erubis (~> 2.7.0) | ||
rails-dom-testing (~> 1.0, >= 1.0.5) | ||
rails-html-sanitizer (~> 1.0, >= 1.0.2) | ||
activejob (4.2.4) | ||
activesupport (= 4.2.4) | ||
globalid (>= 0.3.0) | ||
activemodel (4.2.4) | ||
activesupport (= 4.2.4) | ||
builder (~> 3.1) | ||
activerecord (4.2.4) | ||
activemodel (= 4.2.4) | ||
activesupport (= 4.2.4) | ||
arel (~> 6.0) | ||
activesupport (4.2.4) | ||
i18n (~> 0.7) | ||
json (~> 1.7, >= 1.7.7) | ||
minitest (~> 5.1) | ||
thread_safe (~> 0.3, >= 0.3.4) | ||
tzinfo (~> 1.1) | ||
addressable (2.4.0) | ||
arel (6.0.3) | ||
binding_of_caller (0.7.2) | ||
debug_inspector (>= 0.0.1) | ||
builder (3.2.2) | ||
byebug (9.0.5) | ||
coderay (1.1.0) | ||
coffee-rails (4.1.1) | ||
coffee-script (>= 2.2.0) | ||
railties (>= 4.0.0, < 5.1.x) | ||
coffee-script (2.4.1) | ||
coffee-script-source | ||
execjs | ||
coffee-script-source (1.10.0) | ||
colorize (0.8.1) | ||
concurrent-ruby (1.0.2) | ||
debug_inspector (0.0.2) | ||
diff-lcs (1.2.5) | ||
domain_name (0.5.20160615) | ||
unf (>= 0.0.5, < 1.0.0) | ||
erubis (2.7.0) | ||
execjs (2.7.0) | ||
globalid (0.3.7) | ||
activesupport (>= 4.1.0) | ||
http (2.0.3) | ||
addressable (~> 2.3) | ||
http-cookie (~> 1.0) | ||
http-form_data (~> 1.0.1) | ||
http_parser.rb (~> 0.6.0) | ||
http-cookie (1.0.2) | ||
domain_name (~> 0.5) | ||
http-form_data (1.0.1) | ||
http_parser.rb (0.6.0) | ||
i18n (0.7.0) | ||
jbuilder (2.6.0) | ||
activesupport (>= 3.0.0, < 5.1) | ||
multi_json (~> 1.2) | ||
jquery-rails (4.2.1) | ||
rails-dom-testing (>= 1, < 3) | ||
railties (>= 4.2.0) | ||
thor (>= 0.14, < 2.0) | ||
json (1.8.3) | ||
loofah (2.0.3) | ||
nokogiri (>= 1.5.9) | ||
mail (2.6.4) | ||
mime-types (>= 1.16, < 4) | ||
method_source (0.8.2) | ||
mime-types (3.1) | ||
mime-types-data (~> 3.2015) | ||
mime-types-data (3.2016.0521) | ||
mini_portile2 (2.1.0) | ||
minitest (5.9.0) | ||
multi_json (1.12.1) | ||
newrelic_rpm (3.16.2.321) | ||
nokogiri (1.6.8) | ||
mini_portile2 (~> 2.1.0) | ||
pkg-config (~> 1.1.7) | ||
pg (0.18.4) | ||
pkg-config (1.1.7) | ||
pry (0.10.1) | ||
coderay (~> 1.1.0) | ||
method_source (~> 0.8.1) | ||
slop (~> 3.4) | ||
pry-rails (0.3.4) | ||
pry (>= 0.9.10) | ||
rack (1.6.4) | ||
rack-test (0.6.3) | ||
rack (>= 1.0) | ||
rails (4.2.4) | ||
actionmailer (= 4.2.4) | ||
actionpack (= 4.2.4) | ||
actionview (= 4.2.4) | ||
activejob (= 4.2.4) | ||
activemodel (= 4.2.4) | ||
activerecord (= 4.2.4) | ||
activesupport (= 4.2.4) | ||
bundler (>= 1.3.0, < 2.0) | ||
railties (= 4.2.4) | ||
sprockets-rails | ||
rails-deprecated_sanitizer (1.0.3) | ||
activesupport (>= 4.2.0.alpha) | ||
rails-dom-testing (1.0.7) | ||
activesupport (>= 4.2.0.beta, < 5.0) | ||
nokogiri (~> 1.6.0) | ||
rails-deprecated_sanitizer (>= 1.0.1) | ||
rails-html-sanitizer (1.0.3) | ||
loofah (~> 2.0) | ||
rails_12factor (0.0.3) | ||
rails_serve_static_assets | ||
rails_stdout_logging | ||
rails_serve_static_assets (0.0.5) | ||
rails_stdout_logging (0.0.5) | ||
railties (4.2.4) | ||
actionpack (= 4.2.4) | ||
activesupport (= 4.2.4) | ||
rake (>= 0.8.7) | ||
thor (>= 0.18.1, < 2.0) | ||
rake (11.2.2) | ||
rdoc (4.2.2) | ||
json (~> 1.4) | ||
rspec (3.5.0) | ||
rspec-core (~> 3.5.0) | ||
rspec-expectations (~> 3.5.0) | ||
rspec-mocks (~> 3.5.0) | ||
rspec-core (3.5.2) | ||
rspec-support (~> 3.5.0) | ||
rspec-expectations (3.5.0) | ||
diff-lcs (>= 1.2.0, < 2.0) | ||
rspec-support (~> 3.5.0) | ||
rspec-mocks (3.5.0) | ||
diff-lcs (>= 1.2.0, < 2.0) | ||
rspec-support (~> 3.5.0) | ||
rspec-support (3.5.0) | ||
sass (3.4.22) | ||
sass-rails (5.0.6) | ||
railties (>= 4.0.0, < 6) | ||
sass (~> 3.1) | ||
sprockets (>= 2.8, < 4.0) | ||
sprockets-rails (>= 2.0, < 4.0) | ||
tilt (>= 1.1, < 3) | ||
sdoc (0.4.1) | ||
json (~> 1.7, >= 1.7.7) | ||
rdoc (~> 4.0) | ||
slop (3.6.0) | ||
spring (1.7.2) | ||
sprockets (3.7.0) | ||
concurrent-ruby (~> 1.0) | ||
rack (> 1, < 3) | ||
sprockets-rails (3.1.1) | ||
actionpack (>= 4.0) | ||
activesupport (>= 4.0) | ||
sprockets (>= 3.0.0) | ||
thor (0.19.1) | ||
thread_safe (0.3.5) | ||
tilt (2.0.5) | ||
tzinfo (1.2.2) | ||
thread_safe (~> 0.1) | ||
uglifier (3.0.2) | ||
execjs (>= 0.3.0, < 3) | ||
unf (0.1.4) | ||
unf_ext | ||
unf_ext (0.0.7.2) | ||
web-console (2.3.0) | ||
activemodel (>= 4.0) | ||
binding_of_caller (>= 0.7.2) | ||
railties (>= 4.0) | ||
sprockets-rails (>= 2.0, < 4.0) | ||
|
||
PLATFORMS | ||
ruby | ||
|
||
DEPENDENCIES | ||
byebug | ||
coffee-rails (~> 4.1.0) | ||
colorize | ||
http | ||
jbuilder (~> 2.0) | ||
jquery-rails | ||
newrelic_rpm | ||
pg | ||
pry-rails | ||
rails (= 4.2.4) | ||
rails_12factor | ||
rspec | ||
sass-rails (~> 5.0) | ||
sdoc (~> 0.4.0) | ||
spring | ||
uglifier (>= 1.3.0) | ||
web-console (~> 2.0) | ||
|
||
BUNDLED WITH | ||
1.12.5 |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,62 +1,4 @@ | ||
## Welcome | ||
|
||
If you are reading this, you probably have interviewed or chatted with someone on the team at Zipmark. This is our standard "toy" project we normally like to work on together to see how you think about problems, model them, and make decisions. If you stumbled upon this project randomly and want to give it a shot, please feel free to fork the project and hack away. We would love to see what you come up with. | ||
|
||
An initial version of this project should be doable in a short amount of time (we usually do coding sessions for less than half a day with interviewees), but has many facets that could be improved beyond that inital cut. | ||
|
||
## Objective | ||
|
||
Build a small application that fetches and updates the Federal Reserve's current list of Banks and Routing numbers and then exposes a JSON API where users can lookup a Bank's details by routing number. | ||
|
||
## Resources | ||
|
||
* [Fedwire Directory File Format](https://www.frbservices.org/EPaymentsDirectory/achFormat.html) | ||
* Provides the "rules" for how the bank routing number data file is formatted | ||
|
||
* [Bank Data](https://www.frbservices.org/EPaymentsDirectory/FedACHdir.txt) | ||
* Provides a "fixed-width" data set of all banks registered with the Fed | ||
* Note: fixed-width semantics can be [found here](http://www.softinterface.com/Convert-XLS/Features/Fixed-Width-Text-File-Definition.htm). You'll want to keep this in mind when thinking of how to parse the data set file | ||
|
||
* [Truncated Bank Data](https://gist.github.com/jakehow/3d96b83c4a4a1e6313d4/raw/f2990b4cef86fe9454ba1a643ccee118ca0b5757/truncated_list) | ||
* A subset of the full Bank Data file above | ||
* This is the first 100 lines of the file, much easier to deal with if you are requesting it a lot | ||
|
||
|
||
## Getting Started | ||
|
||
1. Fork this Repo | ||
2. Code up your Version | ||
3. Email us or send a PR so we can check it out | ||
|
||
## Example Behavior | ||
|
||
`curl http://hostname/banks/123456789` | ||
|
||
Output: | ||
|
||
```json | ||
{ | ||
name: "First Bank of Zipmark", | ||
routing_number: "123456789", | ||
record_type: "Record Type", | ||
phone_number: "212-555-1212", | ||
address: { | ||
street: "56 W 22nd St", | ||
street_2: "9th Floor", | ||
city: "New York", | ||
state: "NY", | ||
zip_code: "10010" | ||
} | ||
} | ||
``` | ||
|
||
## Niceties | ||
|
||
* deployable to Heroku | ||
|
||
## Ideas for Enhancements | ||
|
||
* provide a web client that allows a user to enter a routing number into a form and see the results in a browser | ||
* scheduling/backgrounding/resilience | ||
* track updates and changes | ||
* etc | ||
## Instructions | ||
- bundle install | ||
- npm install | ||
- bundle exec rake db:reset to re-seed database | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# Add your own tasks in files placed in lib/tasks ending in .rake, | ||
# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake. | ||
|
||
require File.expand_path('../config/application', __FILE__) | ||
|
||
Rails.application.load_tasks |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// This is a manifest file that'll be compiled into application.js, which will include all the files | ||
// listed below. | ||
// | ||
// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts, | ||
// or any plugin's vendor/assets/javascripts directory can be referenced here using a relative path. | ||
// | ||
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the | ||
// compiled file. | ||
// | ||
// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details | ||
// about supported directives. | ||
// | ||
//= require jquery | ||
//= require jquery_ujs | ||
//= require_tree . |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pyreta the only diff in this PR should be new files you add to write the web server/web application; probably don't want to overwrite this README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mecampbellsoup Had an error pushing with the existing license and README, so I removed it.