Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala, silencer, semanticdb #1181

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Update Scala, silencer, semanticdb #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76d54f1
CI: Scala 2.13.14
fsvehla Oct 21, 2024
fb18cf2
Update silencer
fsvehla Oct 21, 2024
65c6cdb
Update semanticDB
fsvehla Oct 21, 2024
5c3ef15
set scala version to 2.13.15
fsvehla Oct 21, 2024
738c3df
remove unnecessary @nowarn
fsvehla Oct 21, 2024
57402b9
no fatal warnings
fsvehla Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
fail-fast: false
matrix:
java: ['17', '21']
scala: ['2.13.13']
scala: ['2.13.15']
steps:
- name: Checkout current branch
uses: actions/[email protected]
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
fail-fast: false
matrix:
java: ['17', '21']
scala: ['2.12.19', '2.13.13', '3.3.4']
scala: ['2.12.19', '2.13.15', '3.3.4']
platform: ['JVM', 'JS', 'Native']
steps:
- name: Checkout current branch
Expand Down
7 changes: 4 additions & 3 deletions project/BuildHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ object BuildHelper {
val Scala213: String = versions("2.13")
val ScalaDotty: String = "3.3.4"

val SilencerVersion = "1.7.16"
val SilencerVersion = "1.7.19"

private val stdOptions = Seq(
"-deprecation",
Expand All @@ -32,7 +32,8 @@ object BuildHelper {
"-unchecked"
) ++ {
if (sys.env.contains("CI")) {
Seq("-Xfatal-warnings")
// Seq("-Xfatal-warnings") // enable this when we are ready to enforce this
Nil
} else {
Nil // to enable Scalafix locally
}
Expand Down Expand Up @@ -229,7 +230,7 @@ object BuildHelper {
},
semanticdbEnabled := scalaVersion.value != ScalaDotty, // enable SemanticDB
semanticdbOptions += "-P:semanticdb:synthetics:on",
semanticdbVersion := "4.9.2",
semanticdbVersion := "4.10.2",
Test / parallelExecution := true,
incOptions ~= (_.withLogRecompileOnMacro(false)),
autoAPIMappings := true,
Expand Down
2 changes: 1 addition & 1 deletion zio-json-golden/src/main/scala/zio/json/golden/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ package object golden {
else DiffResult.Different(x, y)
}

@nowarn implicit private lazy val diff: Diff[GoldenSample] = (x: GoldenSample, y: GoldenSample) =>
implicit private lazy val diff: Diff[GoldenSample] = (x: GoldenSample, y: GoldenSample) =>
Diff[Json].diff(x.samples, y.samples)

def goldenTest[A: Tag: JsonEncoder](
Expand Down
Loading