🥗 Journal: Test adding an Entry#summary when Writing Entries
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
added a commit
to zinc-collective/convene
that referenced
this pull request
Jan 29, 2024
- zinc-collective#8 - zinc-collective#10 When I started on this, I started with [changes to the data layer], because that's where my brain tends to naturally start. But when I wrote the [system test], I realized it was more of an [`Entries#summary`]. So I am renaming from `Entries#description` to `Entries#summary`. Thank you for coming to my TED Talk. [`Entries#summary`]: zinc-collective#9 [system test]: zinc-collective#9 [changes to the data layer]: zinc-collective#8
zspencer
added a commit
that referenced
this pull request
Jan 29, 2024
- #8 - #10 When I started on this, I started with [changes to the data layer], because that's where my brain tends to naturally start. But when I wrote the [system test], I realized it was more of an [`Entries#summary`]. So I am renaming from `Entries#description` to `Entries#summary`. Thank you for coming to my TED Talk. [`Entries#summary`]: #9 [system test]: #9 [changes to the data layer]: #8
zspencer
force-pushed
the
journal/entry/system-spec-for-summary
branch
2 times, most recently
from
8f24440
to
56f0f2a
Compare
Base automatically changed from
journal/entry/short-description
to
journal/entry-summaries
January 29, 2024 04:40
zspencer
force-pushed
the
journal/entry/system-spec-for-summary
branch
from
56f0f2a
to
fdb42e8
Compare
zspencer
changed the title
Journal: Writing Entries: Test adding Entry#summaryJournal: Test adding an Entry#summary when Writing Entries
zspencer
force-pushed
the
journal/entry/system-spec-for-summary
branch
2 times, most recently
from
d703b48
to
507fe96
Compare
zspencer
force-pushed
the
journal/entry-summaries
branch
from
e6aa446
to
06842f5
Compare
zspencer
force-pushed
the
journal/entry/system-spec-for-summary
branch
from
507fe96
to
0ac0ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal:Entry#summary#10Journal: WritingEntries#2This is a quick line-of-action end-to-end test for setting an
Entry#summary.