Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥔✨ Journal: Writing Entries #2

Open
4 of 6 tasks
Tracked by #1 ...
zspencer opened this issue Jun 15, 2023 · 0 comments
Open
4 of 6 tasks
Tracked by #1 ...

🥔✨ Journal: Writing Entries #2

zspencer opened this issue Jun 15, 2023 · 0 comments
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great

Comments

@zspencer
Copy link
Member

zspencer commented Jun 15, 2023

Use Cases

Polish

@zspencer zspencer changed the title Writing Journal Entries 🥔✨ Journal: Writing Entries Jun 15, 2023
zspencer referenced this issue in zinc-collective/convene Jul 4, 2023
- https://github.com/zinc-collective/convene/issues/1566

Womp womp; apparently I had forgotten to do the `unprocessable_entity`,
which meant that `turbo` was failing miserably instead of replacing the
form when creating or updating a journal entry.

Well; now it's fixed!
zspencer referenced this issue in zinc-collective/convene Jul 4, 2023
- https://github.com/zinc-collective/convene/issues/1566

I was doing some writing and noticed that I tend to drag the text area
to make it bigger.

Now I won't have to do that!
@zspencer zspencer changed the title 🥔✨ Journal: Writing Entries 🥔✨ Journal: Writing Entries Jul 4, 2023
zspencer referenced this issue in zinc-collective/convene Jul 6, 2023
- https://github.com/zinc-collective/convene/issues/1566

I was doing some writing and noticed that I tend to drag the text area
to make it bigger.

Now I won't have to do that!
zspencer referenced this issue in zinc-collective/convene Jul 6, 2023
- https://github.com/zinc-collective/convene/issues/1566

Womp womp; apparently I had forgotten to do the `unprocessable_entity`,
which meant that `turbo` was failing miserably instead of replacing the
form when creating or updating a journal entry.

Well; now it's fixed!
zspencer referenced this issue in zinc-collective/convene Jul 6, 2023
- https://github.com/zinc-collective/convene/issues/1566
- #1630 (comment)

> Not really part of your PR, but now that we have the
> `strip_attributes` gem, it might be worth throwing that on for
> `headline` and `body`, just so that we don't store trailing/preceding
> whitespace.
zspencer referenced this issue in zinc-collective/convene Jul 6, 2023
- https://github.com/zinc-collective/convene/issues/1566
- #1630 (comment)

> Not really part of your PR, but now that we have the
> `strip_attributes` gem, it might be worth throwing that on for
> `headline` and `body`, just so that we don't store trailing/preceding
> whitespace.
zspencer referenced this issue in zinc-collective/convene Jul 13, 2023
- https://github.com/zinc-collective/convene/issues/1662
- https://github.com/zinc-collective/convene/issues/1566

This gets us a little bit closer to being able to browse `Entry` by
`Keyword`s, since each `Entry` will know it's keywords
zspencer referenced this issue in zinc-collective/convene Jul 28, 2023
- https://github.com/zinc-collective/convene/issues/1713
- https://github.com/zinc-collective/convene/issues/1566

I thought I would tilt at this while I waited for the build to go out;
since I noticed I go from an `Entry` to a `Keyword` when trying to
decide what to fill in next when world building.

It also auto-fills the new `Entry` body with the `Keywords` canonical
version and it's aliases!

Which... I need to make a UI for soonish.
zspencer referenced this issue in zinc-collective/convene Jul 28, 2023
- https://github.com/zinc-collective/convene/issues/1713
- https://github.com/zinc-collective/convene/issues/1566

I thought I would tilt at this while I waited for the build to go out;
since I noticed I go from an `Entry` to a `Keyword` when trying to
decide what to fill in next when world building.

It also auto-fills the new `Entry` body with the `Keywords` canonical
version and it's aliases!

Which... I need to make a UI for soonish.
zspencer referenced this issue in zinc-collective/convene Jul 28, 2023
- https://github.com/zinc-collective/convene/issues/1713
- https://github.com/zinc-collective/convene/issues/1566

I thought I would tilt at this while I waited for the build to go out;
since I noticed I go from an `Entry` to a `Keyword` when trying to
decide what to fill in next when world building.

It also auto-fills the new `Entry` body with the `Keywords` canonical
version and it's aliases!

Which... I need to make a UI for soonish.
zspencer referenced this issue in zinc-collective/convene Jul 28, 2023
- https://github.com/zinc-collective/convene/issues/1713
- https://github.com/zinc-collective/convene/issues/1566

I thought I would tilt at this while I waited for the build to go out;
since I noticed I go from an `Entry` to a `Keyword` when trying to
decide what to fill in next when world building.

It also auto-fills the new `Entry` body with the `Keywords` canonical
version and it's aliases!

Which... I need to make a UI for soonish.
zspencer referenced this issue in zinc-collective/convene Aug 3, 2023
`Journal`: `Entry` can be migrated to another `Journal`

- https://github.com/zinc-collective/convene/issues/1566

Also part of the writing I'm doing on https://slipvector.games, I have a
Journal for non-canon (well, several; depending on if it's worldbuilding
or concept art or a story) and then a `Journal` for canon content.

I want to be able to take an entry and move it into the Canon journal;
and I'm fine doing it from the rails console for now; but I probably
will expose a command end-point like
`/journal/:entry_id/migrate_to?journal_id=...&keywords[]=AKeyword&keywords[]=BKeyword`
and add a button on the `Entry#edit` screen to enter the flow for
selecting the Journal / adding Keywords.
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great labels Jan 29, 2024
@zspencer zspencer transferred this issue from zinc-collective/convene Jan 29, 2024
@zspencer zspencer mentioned this issue Jan 29, 2024
3 tasks
zspencer added a commit to zinc-collective/convene that referenced this issue Jan 29, 2024
- zinc-collective#2
- zinc-collective#6
- zinc-collective#4

Clearly, when I started
zinc-collective#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit to zinc-collective/convene that referenced this issue Jan 29, 2024
- zinc-collective#2
- zinc-collective#10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit that referenced this issue Jan 29, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit that referenced this issue Jan 29, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit that referenced this issue Feb 3, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit that referenced this issue Feb 3, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit to zinc-collective/convene that referenced this issue Feb 3, 2024
- When zinc-collective#2, add an zinc-collective#10 so we can eventually display it when zinc-collective#4


* 🧹🥗 `Journal`: Add `Entry#summary` field (#8)

- zinc-collective#10

What I'm driving towards here is similar to
#2055, where a
`Journal::Entry` has an affordance for being opinionated about how it's
represented when linked to in search engines or peer-to-peer sharing; as
well as short text for when there are a several on `Journal#show`.

* 🛠️ `Journal`: Test only the `Journal in CI

While working on
zinc-collective#11, I realized I
missed a piece of the refactor because I was leaning-on-ci as a way to
confirm that everything was working as expected.

Little did I know, CI was not working in this fork. Which makes sense,
because you don't want to automatically turn on all the Workflows when
you fork a project.

This adds a Github Workflow for testing *just* the `Journal`, which
should make detecting oopsie-daisys a bit easier for folks who are only
interested in working on the Journal.

* 🥗 `Journal`: Test adding `Entry#summary` when Writing `Entries`

- zinc-collective#10
- zinc-collective#2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.

* ✨ `Journal`: Save `Entry#summary` when Writing `Entries`

- zinc-collective#2
- zinc-collective#10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Projects
None yet
Development

No branches or pull requests

1 participant