Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates from ranked-model to positioning gem #2430

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rosschapman
Copy link
Contributor

@rosschapman rosschapman commented May 30, 2024

@anaulin and I spent an ensemble pairing on this but eventually ran into issues when manually testing creation of new Gizmos.

  • βœ… The migrations and installation of the positioning code is sound
  • 😒 But, we got a NoMethodError that position_will_change! does not exist on the furniture instance when execution reaches furniture.save in the controller
  • πŸ€” We were curious about it being an issue with STI models, but the gem includes a test case for STI
  • πŸ€” We were also curious about whether our custom Furniture model code might be interacting with the gem in a strange way
  • ⏭️ Thought: rather than hack our way around the Furniture model, we can put this code on standby while we refactor the furniture STI models into standalone models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant