Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup documentation #7

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Cleanup documentation #7

merged 10 commits into from
Jul 24, 2024

Conversation

stewartboyd119
Copy link
Member

@stewartboyd119 stewartboyd119 commented Jul 24, 2024

  1. Remove reference to zlog (zillow internal logging implementation)
  2. Added worker-deadletter and worker-delay
  3. Add maked targets for new examples
  4. Updated readme.md
  5. Updated DeadLetterTopicConfig to honor parent consumer config's clientid

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.86%. Comparing base (a16d04c) to head (e456291).

Files Patch % Lines
work.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   93.77%   93.86%   +0.08%     
==========================================
  Files          17       17              
  Lines        1286     1288       +2     
==========================================
+ Hits         1206     1209       +3     
+ Misses         53       52       -1     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboyd119 stewartboyd119 merged commit 7935b74 into main Jul 24, 2024
2 checks passed
@stewartboyd119 stewartboyd119 deleted the cleanup-documentation branch July 24, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants