Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate kafka tests into github work flow #6

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

stewartboyd119
Copy link
Member

@stewartboyd119 stewartboyd119 commented Jul 23, 2024

  1. Incorporate kafka tests into github workflow
  2. Updated tests to assert that worker exits without error
  3. Updated busy loop pause to respect context cancellation
  4. Updated virtual partition write to respect context cancellation
  5. Added debug logs for reader/processor exit
  6. Removed dependency on github.com/errors package (no need for stack trace info)
  7. Added go report card
  8. Corrected spelling mistakes
  9. Updated coverage.sh script to echo each line
  10. Updated compose.yml (renamed from docker-compose) to use kafka+zookeeper instead of KRAFT implementation (in local usage)
  11. Updated dependencies (confluent-kafka-go/otel)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (68f29be) to head (bc03c44).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   91.47%   93.97%   +2.50%     
==========================================
  Files          17       17              
  Lines        1278     1278              
==========================================
+ Hits         1169     1201      +32     
+ Misses         82       51      -31     
+ Partials       27       26       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

2. Updated busy loop pause to respect context cancellation
3. Added debug logs for reader/processors exit
2. Updated busy loop pause to respect context cancellation
3. Added debug logs for reader/processors exit
4. Removed dependency on github.com/errors package (no need for stack trace info)
@stewartboyd119 stewartboyd119 merged commit a16d04c into main Jul 23, 2024
2 checks passed
@stewartboyd119 stewartboyd119 deleted the containerized-kafka branch July 24, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants