Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema reg deser bugfix #15

Merged
merged 14 commits into from
Sep 24, 2024
Merged

Schema reg deser bugfix #15

merged 14 commits into from
Sep 24, 2024

Conversation

stewartboyd119
Copy link
Member

@stewartboyd119 stewartboyd119 commented Sep 24, 2024

  1. Deserialization previously used implicit schema based on reflection. This showed problems in common schema evolution scenarios (Adding a field). The formatter was updated to be passed the schema explicitily (instead of inferring it).

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (3efce44) to head (3ddc721).

Files with missing lines Patch % Lines
formatter.go 53.57% 7 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   90.58%   89.68%   -0.90%     
==========================================
  Files          18       18              
  Lines        1550     1571      +21     
==========================================
+ Hits         1404     1409       +5     
- Misses         95      104       +9     
- Partials       51       58       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboyd119 stewartboyd119 merged commit ef8e6bc into main Sep 24, 2024
2 checks passed
@stewartboyd119 stewartboyd119 deleted the schema-reg-deser-bugfix branch September 24, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants