Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMPMP-242: Updated WithDeadLetterTopic option to borrow username and password from ConsumerTopicConfig when those issues aren't specified on DeadLetterTopicConfig #11

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

stewartboyd119
Copy link
Member

RMPMP-242: Updated WithDeadLetterTopic option to borrow username and password from ConsumerTopicConfig when those issues aren't specified on DeadLetterTopicConfig

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (658363e) to head (62fe220).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   93.27%   93.29%   +0.02%     
==========================================
  Files          17       17              
  Lines        1278     1283       +5     
==========================================
+ Hits         1192     1197       +5     
- Misses         56       57       +1     
+ Partials       30       29       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboyd119 stewartboyd119 merged commit c0b0f93 into main Sep 6, 2024
2 checks passed
@stewartboyd119 stewartboyd119 deleted the RMPMP-242 branch September 6, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants