using botocore clienterror exception

zillow · May 7, 2024 · 1b3d8c4 · 1b3d8c4
1 parent d4e7d9f
commit 1b3d8c4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/zdatasets/tests/utils/test_secret_fetcher.py b/zdatasets/tests/utils/test_secret_fetcher.py
@@ -2,6 +2,7 @@
 import os
 import unittest
 from unittest import mock
+from botocore.exceptions import ClientError
 
 import boto3
 import pytest
@@ -109,11 +110,11 @@ def test_fetch_aws_secret():
         SecretFetcher(aws_secret_arn="not-json-decodable", key="key").value
 
     # Empty string
-    with pytest.raises(ValueError) as ve:
+    with pytest.raises(ClientError) as ce:
         SecretFetcher(aws_secret_arn="empty")
     assert (
             "Secrets Manager can't find the specified secret value for staging label: AWSCURRENT"
-            == ve.value.response["Error"]["Message"])
+            == ce.value.response["Error"]["Message"])
 
 
 @mock.patch("zdatasets.utils.secret_fetcher.get_current_namespace")