Patch Python 3.8 Build (#17)

* Update build to test Python 3.8 * Fix type hints for Python 3.8
zillow · Oct 25, 2023 · d246e37 · d246e37
1 parent 7ca3f3e
commit d246e37
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -4,15 +4,19 @@ on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+    runs-on: ${{ matrix.os }}
 
     steps:
       - uses: actions/checkout@v4
 
-      - name: Set up Python 3.12
+      - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v4
         with:
-          python-version: '3.12'
+          python-version: ${{ matrix.python-version }}
           cache: 'pip'
           cache-dependency-path: pyproject.toml
 

diff --git a/quantile_forest/tests/test_quantile_forest.py b/quantile_forest/tests/test_quantile_forest.py
@@ -4,7 +4,7 @@
 
 import math
 import warnings
-from typing import Any
+from typing import Any, Dict
 
 import numpy as np
 import pytest
@@ -41,7 +41,7 @@
 X_california = california.data[perm]
 y_california = california.target[perm]
 
-FOREST_REGRESSORS: dict[str, Any] = {
+FOREST_REGRESSORS: Dict[str, Any] = {
     "ExtraTreesQuantileRegressor": ExtraTreesQuantileRegressor,
     "RandomForestQuantileRegressor": RandomForestQuantileRegressor,
 }