Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the release branch with our changes to the kserve fork #6

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Update the release branch with our changes to the kserve fork #6

merged 11 commits into from
Feb 29, 2024

Conversation

akdigitalself
Copy link
Collaborator

@akdigitalself akdigitalself commented Feb 27, 2024 •
edited
Loading

This MR updates the release branch with our changes to the kserve fork.

Changes:

  • Ported the changes from the zillow/kserve branch.
  • Updated the logic in gitlab-ci.yaml as the logic to identify the version has changed a little in the open source code. You can see those changes with the diff of the first and the last commit to this branch. Confirmed that the version number is being generated as expected.

If there any other changes needed to the fork, a separate MR will be created.

@akdigitalself akdigitalself changed the title Draft: Copied over our changes in zillow/kserve Draft: updates the release branch with our changes to the kserve fork Feb 28, 2024
@akdigitalself
Copy link
Collaborator Author

I don't remember what issue we had with table_logger. Now it uses tabulate instead. So I haven't ported over this change. Let me know if I should.

akdigitalself
akdigitalself commented Feb 28, 2024
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
@akdigitalself akdigitalself changed the title Draft: updates the release branch with our changes to the kserve fork Update the release branch with our changes to the kserve fork Feb 28, 2024
@akdigitalself akdigitalself self-assigned this Feb 28, 2024
@akdigitalself akdigitalself marked this pull request as ready for review February 28, 2024 23:33
@akdigitalself akdigitalself merged commit 1c212d9 into zillow/release-0.10.2 Feb 29, 2024
34 of 41 checks passed
@akdigitalself akdigitalself deleted the zillow/ash/add-our-changes-to-v0.10 branch February 29, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peilun-Li Peilun-Li Peilun-Li approved these changes

Assignees

@akdigitalself akdigitalself

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akdigitalself @Peilun-Li