Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to serious multi-byte testing #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

switch to serious multi-byte testing #13

wants to merge 1 commit into from

Conversation

zikaari
Copy link
Owner

@zikaari zikaari commented Jun 27, 2018

No description provided.

@zikaari zikaari requested a review from aeschli June 27, 2018 06:34
@zikaari
Copy link
Owner Author

zikaari commented Nov 12, 2019

@aeschli any thoughts on including this in the next release?

@aeschli
Copy link
Collaborator

aeschli commented Nov 12, 2019 •
edited
Loading

+1 for improving our benchmark. But I would suggest to add a new test instead of replacing the existing one.
Also I would suggest avoiding randomized inputs but use real-world examples.

  • avoid random to make it reproducible
  • avoid optimizing against inputs that are rare or net even existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschli aeschli Awaiting requested review from aeschli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zikaari @aeschli